Skip to content

chore: add readme and adapt license#4

Merged
Uzlopak merged 2 commits intomainfrom
readme-license
Aug 8, 2025
Merged

chore: add readme and adapt license#4
Uzlopak merged 2 commits intomainfrom
readme-license

Conversation

@Uzlopak
Copy link
Copy Markdown
Collaborator

@Uzlopak Uzlopak commented Aug 8, 2025

@mcollina
@jsumners

Modified the license, but I personally think it is a reimplementation.

I extended the readme.

Just one remark:

If I would had no limitations, i would have generated a new Function via the Function constructor. That would have been the fastest solution possible. But I assume that this would have resulted in devs complaining about pino breaking in vercel environments and other environments where eval and new Function() is forbidden or removed. If you want I can add such a Function Generator in the next iteration. I dont think it will take much effort to implement that. We have already all lookupArrays for fast string generation. And we have the tokenizer. I guess that would be like 20 more lines(?). Anyhow, i dont know how the heuristics are in vercel and co, and if they throw an Error only by detecting new Function calls?

But I didnt investigated the potential perf gain of such an approach and well... this package is already faster than the original by a magnitude.

@mcollina
Copy link
Copy Markdown
Member

mcollina commented Aug 8, 2025

You can use New function

@mcollina
Copy link
Copy Markdown
Member

mcollina commented Aug 8, 2025

Please remove "dependency review" not sure what that is.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak
Copy link
Copy Markdown
Collaborator Author

Uzlopak commented Aug 8, 2025

@jsumners ptal

@Uzlopak Uzlopak merged commit aee3189 into main Aug 8, 2025
8 checks passed
@Uzlopak Uzlopak deleted the readme-license branch August 9, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants