Add Input/Output model splitting to GraphQL mutation engine#60
Draft
FionaBronwen wants to merge 2 commits intofionabronwen/emitter-integrationfrom
Draft
Add Input/Output model splitting to GraphQL mutation engine#60FionaBronwen wants to merge 2 commits intofionabronwen/emitter-integrationfrom
FionaBronwen wants to merge 2 commits intofionabronwen/emitter-integrationfrom
Conversation
FionaBronwen
force-pushed
the
fionabronwen/emitter-integration
branch
from
b4208ef to
336b711
Compare
FionaBronwen
force-pushed
the
fionabronwen/input-output-splitting
branch
from
d900bb0 to
1bd1b71
Compare
FionaBronwen
force-pushed
the
fionabronwen/emitter-integration
branch
from
336b711 to
ccc10f6
Compare
FionaBronwen
force-pushed
the
fionabronwen/input-output-splitting
branch
from
1bd1b71 to
0c1ebbc
Compare
FionaBronwen
force-pushed
the
fionabronwen/emitter-integration
branch
from
ccc10f6 to
9c89a06
Compare
FionaBronwen
force-pushed
the
fionabronwen/input-output-splitting
branch
from
0c1ebbc to
da1b154
Compare
FionaBronwen
force-pushed
the
fionabronwen/emitter-integration
branch
8 times, most recently
from
8cd1884 to
c469bda
Compare
FionaBronwen
force-pushed
the
fionabronwen/input-output-splitting
branch
4 times, most recently
from
64b077f to
50cd3e4
Compare
FionaBronwen
force-pushed
the
fionabronwen/emitter-integration
branch
2 times, most recently
from
decde60 to
bcfae7d
Compare
- Update GraphQLMutationOptions with usageFlag and mutationKey - GraphQLModelMutation adds 'Input' suffix for input types - GraphQLMutationEngine.mutateModel() returns ModelMutationResult with separate input/output mutations based on resolveUsages() - ModelTypeMap supports GraphQLInputObjectType for input types - Schema emitter handles both input and output model variants - Add 5 new tests for input/output splitting behavior
FionaBronwen
force-pushed
the
fionabronwen/input-output-splitting
branch
from
50cd3e4 to
56e78bf
Compare
steverice
requested changes
Jan 29, 2026
| this.engine = new MutationEngine(tk, graphqlMutationRegistry); | ||
|
|
||
| // Resolve usages once at construction time | ||
| this.usageTracker = resolveUsages(namespace); |
There was a problem hiding this comment.
This is an expensive operation so we probably don't want to do it in the constructor.
Expensive calls can be made lazily; i.e. if we ask for usage information (in getUsage) and we have not yet resolved usages, we do so (and store the result). Callers should also have the flexibility to trigger the resolve explicitly to optimize their call flow.
| */ | ||
| readonly usageFlag: UsageFlags; | ||
|
|
||
| constructor(usageFlag: UsageFlags = UsageFlags.None) { |
There was a problem hiding this comment.
It's valid for me to do
new GraphQLMutationOptions(usageFlag: UsageFlags.Input | UsageFlags.Output);or any other combination of the flags.
So we either need to account for this in mutationKey(), or do an explicit check at construction time that usageFlag is only the values that we expect.
| } | ||
| return this.materializeOutputType(name, tspModel); | ||
| return this.materializeOutputType(tspModel, name); | ||
| } |
There was a problem hiding this comment.
Why do we need to pass the name explicitly here; can't we access the name property on the tspModel in the functions we're calling?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds usage-aware model mutations that create separate input and output type variants based on how models are used in operations. This brings the TSP models in line with the GraphQL requirement of separate input and output types.
Changes
GraphQLMutationOptions- AddedusageFlagandmutationKeyfor usage-aware cachingGraphQLModelMutation- Adds "Input" suffix for input typesGraphQLMutationEngine.mutateModel()- ReturnsModelMutationResultwith separate input/output mutationsModelTypeMap- SupportsGraphQLInputObjectTypefor input typesHow it works