Migrate test-host.ts to createTester framework#68
Open
FionaBronwen wants to merge 1 commit intofionabronwen/graphql-mutation-engine-v2from
Open
Migrate test-host.ts to createTester framework#68FionaBronwen wants to merge 1 commit intofionabronwen/graphql-mutation-engine-v2from
FionaBronwen wants to merge 1 commit intofionabronwen/graphql-mutation-engine-v2from
Conversation
FionaBronwen
force-pushed
the
fionabronwen/graphql-mutation-engine-v2
branch
from
70e7589 to
84b7764
Compare
FionaBronwen
force-pushed
the
fionabronwen/graphql-migrate-test-host
branch
from
ebc0664 to
f3377f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the legacy
createTestHost/createTestWrappertesting setup with thecreateTesterAPIintroduced in microsoft#7151.
Changes
test-host.ts: ReplacecreateTestHost/createTestWrapperwithcreateTesterandEmitterTester. UsecompileAndDiagnosewithresult.outputsinstead of manually reading from the test filesystem. Removeunused standalone diagnose and
compileAndDiagnosehelper functions.src/testing/index.ts: DeleteGraphQLTestLibrary.createTester resolves libraries by package name and does not need aTypeSpecTestLibrary` object.package.json: Remove the./testingexport (no longer has a source file).What's preserved
The public test API (
Tester,EmitterTester,emitSingleSchema,emitSingleSchemaWithDiagnostics,emitWithDiagnostics,GraphQLTestResult) is unchanged. No test files required modifications.