Add GraphQL ID scalar and built-in name collision warning#69
Open
FionaBronwen wants to merge 2 commits intofionabronwen/graphql-mutation-engine-v2from
Open
Add GraphQL ID scalar and built-in name collision warning#69FionaBronwen wants to merge 2 commits intofionabronwen/graphql-mutation-engine-v2from
FionaBronwen wants to merge 2 commits intofionabronwen/graphql-mutation-engine-v2from
Conversation
FionaBronwen
force-pushed
the
fionabronwen/graphql-mutation-engine-v2
branch
from
70e7589 to
84b7764
Compare
FionaBronwen
force-pushed
the
fionabronwen/graphql-scalar-id
branch
from
82569eb to
621c9a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scalar ID extends stringto the GraphQL library (lib/scalars.tsp), giving users a blessed way to express GraphQL's built-in ID type in TypeSpec (e.g.,id: GraphQL.ID)GraphQL.ID(and scalars extending it) as a built-in — rename toIDand stripbaseScalar, so it emits as GraphQL's native ID type rather than a custom scalar definition
String,Int,Float,Boolean,ID)Test plan
Added the following new tests:
GraphQL.IDis renamed to built-inIDSubId extends MyId extends GraphQL.ID) resolves to built-inIDFloatextends string emitsgraphql-builtin-scalar-collisionwarningAll 106 existing + new tests pass