Ignore dev/testing files for distribution builds #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.gitattributes` file was missing. It's actually a good idea to exclude unneeded dev files from the final production zip archive file, which is also downloaded by composer (unless --prefer -source is specified). Those files are indeed only useful when working on the library itself.
Contributor
Author
|
@estevanjantsk Could you have a look? 🤗 |
SpaceOven
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.gitattributesfile was missing from theclient-php.It's actually a good idea to exclude unneeded dev files from the the production archive, which is used by composer for instance.
The files I mentioned are only useful when working on the library itself.
If you are not familiar with
.gitattributes/export-ignore, you can find further info below:I hope it helps! 🙂