Add path params in websocket uri #397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a functional POC (prof of concept) for #395.
The code works but need some adjustment.
For Undertow:
For Jetty the code is similar with the code presented in #360 (comment).
Also this PR comes with a hidden nice feature,
UriMatcherwithDefaultUriMatcher. So, theDefaultRouterwas spitted in two parts. It's more easy to implement a custom router with uri matcher (maybe some one wants another notation for path parameters or supply a more fast uri matching algorithm).In
WebSocketContextyou will can access the parameters value (I have already these information), similar with the approach used in Request. Also,WebSocketContextwill contain other information like session, request header.