Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

removes unnecessary #fetchUrl call #100

Closed
aars wants to merge 1 commit into from
Closed

removes unnecessary #fetchUrl call #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion addon/adapters/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ export default Ember.Object.extend(FetchMixin, Evented, {
// use resource's service if in container, otherwise use this service to fetch
let owner = (typeof getOwner === 'function') ? getOwner(this) : this.container;
let service = owner.lookup('service:' + pluralize(type)) || this;
url = this.fetchUrl(url);
return service.fetch(url, { method: 'GET' });
Copy link
Owner

@pixelhandler pixelhandler Sep 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aars I'm pretty sure this is the hook I use to be sure that when a proxy server is in use the url in the payload for the relationship is replaced with the url of the proxy server.

Copy link
Collaborator Author

@aars aars Sep 12, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this is that hook. In adapter.fetch itself, which is good.

Copy link
Owner

@pixelhandler pixelhandler Sep 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aars I'll need to step trough the call stack for a request to updateRelationship (PATCH) I think that relationship requests do not use adapter.fetch.

Copy link
Collaborator Author

@aars aars Sep 14, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updateRelationship calls patchRelationship which calls fetch

Even if updateRelationship's stack did not call fetch, I removed fetchUrl from findRelated, which is unrelated to updateRelationship or patchRelationship.

But do check to be sure.

},

Expand Down