Relese/v0.6.8-10#109
Merged
Merged
Conversation
easymde ^2.20.0 → ^2.21.0 mermaid ^11.14.0 → ^11.15.0 suneditor ^3.1.2 → ^3.1.3 swagger-ui-dist 5.32.5 → 5.32.6 tom-select ^2.6.0 → ^2.6.1
- Removed leads routes and templates - Removed opportunities routes and templates
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if comm.status != 'pending': | ||
| flash(f'Communication is already {comm.status}.', 'warning') | ||
| return redirect(request.referrer or url_for('onboarding.index')) | ||
| return redirect(request.referrer or url_for(_EP_INDEX)) |
| if not comm.recipient_email: | ||
| flash('No recipient email configured for this communication.', 'danger') | ||
| return redirect(request.referrer or url_for('onboarding.index')) | ||
| return redirect(request.referrer or url_for(_EP_INDEX)) |
|
|
||
| db.session.commit() | ||
| return redirect(request.referrer or url_for('onboarding.index')) | ||
| return redirect(request.referrer or url_for(_EP_INDEX)) |
| if comm.status != 'pending': | ||
| flash(f'Cannot cancel - communication is already {comm.status}.', 'warning') | ||
| return redirect(request.referrer or url_for('onboarding.index')) | ||
| return redirect(request.referrer or url_for(_EP_INDEX)) |
ooopsies
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mixed batch of bug fixes, UX improvements, and cleanup. Fixes several broken flows in Evaluations, Onboarding/Offboarding, and Peripherals; adds three quality-of-life features to HR processes; and removes the legacy
leads/opportunitiesmodules that had been superseded byrequirements/evaluations.Type of Change
Impact Assessment
Does this change affect other components?
leads,opportunities(routes, templates, tests)Does this change require a new database migration?
009_add_notes_to_onboarding_process: adds nullablenotestext column toonboarding_processDoes this change require new or updated tests?
test_leads.py(module deleted)Does this change require documentation updates?
Additional Notes
Bugs fixed:
GET /evaluations/<id>returned 500 due to Jinja2 syntax error indetail.html({{ super() %}missing closing brace)opportunitiesblueprint)revoke_service_accesswas redirecting toonboarding_detailinstead ofoffboarding_detailitem_type == 'Service'but items are created withitem_type == 'ServiceOwnership'brandsvariable was missing fromedit_peripheral()render callFeatures added: