Skip to content

[Issue #1321] Allow ObjectStorageManager to use file storage scheme #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bianhq merged 2 commits into from
May 1, 2026
Merged

[Issue #1321] Allow ObjectStorageManager to use file storage scheme #1322

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa044ef
Allow ObjectStorageManager to use file storage scheme
AntiO2 Apr 28, 2026
38191a0
Replace hardcoded string comparison with Storage.Scheme enum constants
AntiO2 Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions pixels-retina/src/main/java/io/pixelsdb/pixels/retina/ObjectStorageManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
import io.pixelsdb.pixels.common.exception.RetinaException;
import io.pixelsdb.pixels.common.physical.*;
import io.pixelsdb.pixels.common.utils.ConfigFactory;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import java.io.IOException;
import java.nio.ByteBuffer;
Expand All @@ -31,6 +33,7 @@
*/
public class ObjectStorageManager
{
private static final Logger logger = LogManager.getLogger(ObjectStorageManager.class);
private static volatile ObjectStorageManager instance;
private final Storage storage;
private final String path;
Expand All @@ -49,17 +52,12 @@ private ObjectStorageManager() throws RetinaException
String storageScheme = config.getProperty("retina.buffer.object.storage.scheme");
try
{
switch(storageScheme)
if (!Storage.Scheme.minio.equals(storageScheme) && !Storage.Scheme.s3.equals(storageScheme))
{
case "s3":
this.storage = StorageFactory.Instance().getStorage(Storage.Scheme.s3);
break;
case "minio":
this.storage = StorageFactory.Instance().getStorage(Storage.Scheme.minio);
break;
default:
throw new RetinaException("Unsupported storage scheme: " + storageScheme);
logger.warn("ObjectStorageManager is configured with non-standard storage scheme '{}'; " +
"expected production schemes are 's3' or 'minio'", storageScheme);
}
this.storage = StorageFactory.Instance().getStorage(storageScheme);
} catch (IOException e)
{
throw new RetinaException("Failed to get storage", e);
Expand Down
Loading