Removed PLD_header delete statement #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLD_header::~PLD_header had an uneeded delete statement. This was causing a seg fault when quitting poll2 on nitemp.
Member
|
This patch will need to be tested on nitemp. Is this the in-crate computer of @wapman's? |
Contributor
Author
|
I have tested it on nitemp and it works, I did the development work from there. nitemp is @wapmanzoo's in crate computer. |
akeeler
pushed a commit
to akeeler/paass
that referenced
this pull request
Mar 7, 2017
Removed PLD_header delete statement Former-commit-id: befd7dd
spaulaus
added a commit
to spaulaus/paass
that referenced
this pull request
Nov 21, 2020
The logic tree converting strings to firmware types wasn't assigning the proper firmware for 34455. This caused problems while decoding the trace lengths and meant that the software thought there was an error. Strange that it didn't catch this all the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLD_header::~PLD_header had an uneeded delete statement. This was causing a seg fault when quitting poll2 on nitemp.