Skip to content

Conversation

@Samueru-sama
Copy link
Member

the opus package often fails due to connection issues.

@Samueru-sama Samueru-sama requested a review from Copilot September 9, 2025 05:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds retry logic for package builds that frequently fail due to connection issues, particularly for the opus package. The changes implement a standardized cleanup mechanism across all build scripts and add a retry loop in the CI workflow.

  • Implements consistent temporary build directory management across all build scripts
  • Adds signal traps for cleanup on script interruption or exit
  • Introduces a retry mechanism in CI that attempts builds up to 3 times before failing

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
qt6-base-mini.sh Adds tmpbuild directory and cleanup trap
opus-mini.sh Adds tmpbuild directory and cleanup trap
mesa-nano.sh Adds tmpbuild directory and cleanup trap
mesa-mini.sh Adds tmpbuild directory and cleanup trap
mangohud-mini.sh Refactors to use tmpbuild directory and cleanup trap
llvm-nano.sh Adds tmpbuild directory and cleanup trap
llvm-mini.sh Adds tmpbuild directory and cleanup trap
libxml2-mini.sh Adds tmpbuild directory and cleanup trap
intel-media-driver-mini.sh Adds tmpbuild directory and cleanup trap
gtk4-mini.sh Adds tmpbuild directory and cleanup trap
gtk3-mini.sh Adds tmpbuild directory and cleanup trap
ffmpeg-mini.sh Adds tmpbuild directory and cleanup trap
.github/workflows/blank.yml Implements retry logic for package builds with up to 3 attempts

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Samueru-sama Samueru-sama merged commit 404e59c into main Sep 9, 2025
25 checks passed
@Samueru-sama Samueru-sama deleted the retries branch September 21, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants