Skip to content

fix!: codename should be null on non-lts (#21) #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wesleytodd merged 1 commit into from
Jul 16, 2024
Merged

fix!: codename should be null on non-lts (#21) #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ async function getLatestVersionsByCodename (now, cache, mirror) {
const aliases = versions.reduce((obj, ver) => {
const { major, minor, patch, tag } = splitVersion(ver.version)
const versionName = major !== '0' ? `v${major}` : `v${major}.${minor}`
const codename = ver.lts ? ver.lts.toLowerCase() : versionName
const codename = ver.lts ? ver.lts.toLowerCase() : null
const version = tag !== '' ? `${major}.${minor}.${patch}-${tag}` : `${major}.${minor}.${patch}`
const s = schedule[versionName]

Expand Down
5 changes: 5 additions & 0 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,4 +177,9 @@ suite('nv', () => {
assert.strictEqual(versions[0].major, 0)
assert.strictEqual(versions[0].isLts, false)
})

test('codename null on non-lts', async () => {
const versions = await nv('0.8.0', { now })
assert.strictEqual(versions[0].codename, null)
})
})