Conversation
ToddKerpelman
approved these changes
Mar 25, 2024
Contributor
ToddKerpelman
left a comment
There was a problem hiding this comment.
I haven't tested it (you want me to?), but the changes themselves LGTM>
dtroupe-plaid
approved these changes
Mar 25, 2024
Collaborator
dtroupe-plaid
left a comment
There was a problem hiding this comment.
I ran the new iOS React Native Demo without any issues.
FWIW - in my experience it's easier to just create an entirely new app when upgrading several RN versions. They just copy the typescript code from the old app into the new one.
LGTM 🎉
Collaborator
Author
|
So this was working for me, but later broke. It turns out I was hitting https://stackoverflow.com/questions/77783044/rctthirdpartyfabriccomponentsprovider-mm-build-input-file-cannot-be-found-react and ended up needing this fix facebook/react-native#42639 which meant I had to upgrade to .74 as well, which was a really difficult migration. Ugh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My project to upgrade the deps for the tiny quickstart took on a life of its own when I got to the react native section. As it turns out, the react native tiny quickstart for ios doesn't work with xcode 15.3 because of this issue:
facebook/react-native#43335
Anyway, like the naive fool I am, I decided to resolve this issue by upgrading to the version of React Native that contains the fix. "It's going from .71.14 to .73.6", I told myself, "how bad could it be?"
Anyway, 8 hours later, here we are!
Of note:
-Removed the clipboard package because it doesn't seem to be compatible with newer versions of RN (see Error to Deploy to Android RN 0.73.2 react-native-clipboard/clipboard#225) and I don't think we really needed it anyway
There's also a caveat: npm install will only work if I run it with the
--legacy-peer-depsflag. I really don't like this for a sample app, but also I am using the dependencies recommended by the react native upgrade helper, so I'm not quite sure what to do about it.