Skip to content

Conversation

@area363
Copy link
Contributor

@area363 area363 commented May 13, 2021

This PR adds block_hash to the origin HackAndSlash schema. This should be merged after the Libplanet PR #1296 is merged and bumped.

@area363 area363 requested a review from longfin May 13, 2021 11:15
@area363 area363 self-assigned this May 13, 2021
@@ -1,3 +1,5 @@
using System.Reactive;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this using needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must've left it when trying other things 😅. It's been removed now, thank you for checking!

@longfin
Copy link
Member

longfin commented May 20, 2021

@area363 it's conflicting now. 😅

@area363
Copy link
Contributor Author

area363 commented May 20, 2021

This should be merged after #25 is resolved because ev.BlockHash.ToString() doesn't work at this point 😿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants