Skip to content

Conversation

@jonny-jeahyunchoi
Copy link
Contributor

@jonny-jeahyunchoi jonny-jeahyunchoi commented Nov 24, 2025

Automatically generated pull request. Please review.


Note

Adds Infinite Tower UI localization keys and refines multi-language translations for runes, items, collections, and arena/anniversary descriptions.

  • i18n/Localization:
    • New UI strings: Add UI_INFINITETOWER_* keys for Infinite Tower (titles, floor info/rewards, buttons, badges, conditions).
    • System messages: Tweak UI_ADDRESS_STATE_SET_REQUIRED/SET_SUCCESS/SET_FAILURE phrasing/punctuation in ES/TH and others.
  • Content updates:
    • Runes/Items: Correct and standardize RUNE_NAME_10044~10049, ITEM_NAME_10044~10049 and corresponding ITEM_DESCRIPTION_10043~10050 across languages (notably Spanish terms like “Runa del Creador Odin”, “Runa ATK de Yggdrasil”, “VEL”).
    • Arena winners: Update descriptions for August/September/October 2025 winners (ITEM_DESCRIPTION_49900043, ...44, ...45).
    • Lore items: Refine descriptions for ITEM_DESCRIPTION_40100045 (Dagr), ...40100049, ...40100050, ...40100055, ...40100056 across locales.
    • Anniversary content: Add ITEM_NAME_10770010 and adjust descriptions for 2nd Anniversary Aura/Grimoire (ITEM_DESCRIPTION_10670004, ...10770010, ...40100059, ...49900050).
    • Collections: Minor fixes (e.g., COLLECTION_NAME_300039 Spanish), and additions for season winners.

Written by Cursor Bugbot for commit 046a4da. This will update automatically on new commits. Configure here.

@jonny-jeahyunchoi jonny-jeahyunchoi requested a review from a team as a code owner November 24, 2025 08:38
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

"ITEM_NAME_40100050","PheUs,SharkBa,Triplexmazi","PheUs,SharkBa,Triplexmazi","PheUs, SharkBa, Triplexmazi","PheUs、SharkBa、Triplexmazi","PheUs, SharkBa, Triplexmazi","เฟอัส,ชาร์คบา,ไตรเพล็กซ์มาซี","PheUs,SharkBa,Triplexmazi","PheUs,SharkBa,Triplexmazi","PheUs、SharkBa、Triplexmazi","PheUs、SharkBa、Triplexmazi","PheUs,SharkBa,Triplexmazi","PheUs,SharkBa,Triplexmazi"
"ITEM_DESCRIPTION_40100050","The Valkyries were perplexed. Having been ordered to bring back the strongest warrior, they arrived only to find three champions standing face-to-face. In the end, they decided to take them all to Valhalla. Thus, the champions of Heimdall’s Arena in the summer season of 2025 became warriors of Valhalla.","발키리들은 당황했다. 최강자를 데려오라는 명령을 받고 도착한 곳에는 세 명의 전사가 서로를 마주하며 서 있었다. 결국 그들은 세 명 모두를 발할라로 데려가기로 했다. 그렇게 2025년 여름 시즌 헤임달의 아레나 챔피언들은 발할라의 전사가 되었다.","As Valquírias ficaram perplexas. Tendo recebido ordens para trazer de volta o guerreiro mais forte, chegaram apenas para encontrar três campeões frente a frente. No fim, decidiram levá-los todos para Valhalla. Assim, os campeões da Arena de Heimdall no verão de 2025 se tornaram guerreiros de Valhalla.","ヴァルキュリーたちは困惑した。最強の戦士を連れ戻すよう命じられたにもかかわらず、到着した彼らは三人の勇者が向かい合って立っているのを見つけた。最終的に、彼らは全員をヴァルハラへ連れて行くことを決意した。こうして、2025年夏のヘイムダル闘技場の覇者たちは、ヴァルハラの戦士となった。","Las Valquirias estaban perplejas. Tras recibir la orden de traer de vuelta al guerrero más fuerte, llegaron y se encontraron con tres campeones enfrentados. Finalmente, decidieron llevarlos a todos al Valhalla. Así, los campeones de la Arena de Heimdall del verano de 2025 se convirtieron en guerreros del Valhalla.","เหล่าวาลคิรีต่างงุนงง เมื่อได้รับคำสั่งให้นำนักรบที่แข็งแกร่งที่สุดกลับมา พวกเขาก็มาถึงและพบเพียงนักรบสามคนยืนประจันหน้ากัน ท้ายที่สุดพวกเขาจึงตัดสินใจพาพวกเขาทั้งหมดไปยังวัลฮัลลา ดังนั้น เหล่านักรบแห่งลานประลองไฮม์ดัลล์ในฤดูร้อนปี 2025 จึงกลายเป็นนักรบแห่งวัลฮัลลา","Para Valkyrie kebingungan. Setelah diperintahkan untuk membawa kembali prajurit terkuat, mereka tiba hanya untuk mendapati tiga juara berdiri berhadapan. Akhirnya, mereka memutuskan untuk membawa mereka semua ke Valhalla. Dengan demikian, para juara Arena Heimdall pada musim panas 2025 menjadi prajurit Valhalla.","Валькирии были в замешательстве. Получив приказ привести сильнейшего воина, они прибыли и обнаружили трёх воинов, стоящих лицом к лицу. В конце концов, они решили забрать их всех в Вальхаллу. Так, чемпионы Арены Хеймдалля летом 2025 года стали воинами Вальхаллы.","女武神们感到困惑。她们奉命带回最强的战士,却发现三位勇士面对面站着。最终,她们决定将三人全部带往瓦尔哈拉。就这样,2025年夏季海姆达尔竞技场的冠军们成为了瓦尔哈拉的战士。","女武神們感到困惑。她們奉命帶回最強的戰士,卻發現三位勇士面對面站著。最終,她們決定將三人全部帶到瓦爾哈拉。就這樣,2025年夏季海姆達爾競技場的冠軍們成為了瓦爾哈拉的戰士。","Nataranta ang mga Valkyry. Dahil inutusang ibalik ang pinakamalakas na mandirigma, dumating lamang sila upang makahanap ng tatlong kampeon na nakatayo nang harapan. Sa huli, nagpasya silang dalhin silang lahat sa Valhalla. Kaya, ang mga kampeon ng Heimdall's Arena sa panahon ng tag-araw ng 2025 ay naging mga mandirigma ng Valhalla.","Các Valkyrie vô cùng bối rối. Được lệnh mang chiến binh mạnh nhất trở về, họ đến nơi chỉ để thấy ba nhà vô địch đang đứng đối mặt nhau. Cuối cùng, họ quyết định đưa tất cả đến Valhalla. Vậy là, những nhà vô địch của Đấu trường Heimdall vào mùa hè năm 2025 đã trở thành chiến binh của Valhalla."
"ITEM_DESCRIPTION_40100050","The Valkyries were perplexed. Having been ordered to bring back the strongest warrior, they arrived only to find three champions standing face-to-face. In the end, they decided to take them all to Valhalla. Thus, the champions of Heimdall’s Arena in the summer season of 2025 became warriors of Valhalla.","발키리들은 당황했다. 최강자를 데려오라는 명령을 받고 도착한 곳에는 세 명의 전사가 서로를 마주하며 서 있었다. 결국 그들은 세 명 모두를 발할라로 데려가기로 했다. 그렇게 2025년 여름 시즌 헤임달의 아레나 챔피언들은 발할라의 전사가 되었다.","As Valquírias ficaram perplexas. Tendo recebido ordens para trazer de volta o guerreiro mais forte, chegaram apenas para encontrar três campeões frente a frente. No fim, decidiram levá-los todos para Valhalla. Assim, os campeões da Arena de Heimdall no verão de 2025 se tornaram guerreiros de Valhalla.","ヴァルキュリーたちは困惑した。最強の戦士を連れ戻すよう命じられたにもかかわらず、到着した彼らは三人の勇者が向かい合って立っているのを見つけた。最終的に、彼らは全員をヴァルハラへ連れて行くことを決意した。こうして、2025年夏のヘイムダル闘技場の覇者たちは、ヴァルハラの戦士となった。","Las Valquirias estaban perplejas. Tras recibir la orden de traer al guerrero más fuerte, al llegar se encontraron con tres campeones enfrentados. Finalmente, decidieron llevarlos a todos al Valhalla. Así, los campeones de la Arena de Heimdall en el verano de 2025 se convirtieron en guerreros del Valhalla.","เหล่าวาลคิรีต่างงุนงง เมื่อได้รับคำสั่งให้นำนักรบที่แข็งแกร่งที่สุดกลับมา พวกเขาก็มาถึงและพบเพียงนักรบสามคนยืนประจันหน้ากัน ท้ายที่สุดพวกเขาจึงตัดสินใจพาพวกเขาทั้งหมดไปยังวัลฮัลลา ดังนั้น เหล่านักรบแห่งลานประลองไฮม์ดัลล์ในฤดูร้อนปี 2025 จึงกลายเป็นนักรบแห่งวัลฮัลลา","Para Valkyrie kebingungan. Setelah diperintahkan untuk membawa kembali prajurit terkuat, mereka tiba hanya untuk mendapati tiga juara berdiri berhadapan. Akhirnya, mereka memutuskan untuk membawa mereka semua ke Valhalla. Dengan demikian, para juara Arena Heimdall pada musim panas 2025 menjadi prajurit Valhalla.","Валькирии были в замешательстве. Получив приказ привести сильнейшего воина, они прибыли и обнаружили трёх воинов, стоящих лицом к лицу. В конце концов, они решили забрать их всех в Вальхаллу. Так, чемпионы Арены Хеймдалля летом 2025 года стали воинами Вальхаллы.","女武神们感到困惑。她们奉命带回最强的战士,却发现三位勇士面对面站着。最终,她们决定将三人全部带往瓦尔哈拉。就这样,2025年夏季海姆达尔竞技场的冠军们成为了瓦尔哈拉的战士。","女武神們感到困惑。她們奉命帶回最強的戰士,卻發現三位勇士面對面站著。最終,她們決定將三人全部帶到瓦爾哈拉。就這樣,2025年夏季海姆達爾競技場的冠軍們成為了瓦爾哈拉的戰士。","Nataranta ang mga Valkyry. Dahil inutusang ibalik ang pinakamalakas na mandirigma, dumating lamang sila upang makahanap ng tatlong kampeon na nakatayo nang harapan. Sa huli, nagpasya silang dalhin silang lahat sa Valhalla. Kaya, ang mga kampeon ng Heimdall's Arena sa panahon ng tag-araw ng 2025 ay naging mga mandirigma ng Valhalla.","Các Valkyrie vô cùng bối rối. Được lệnh mang chiến binh mạnh nhất trở về, họ đến nơi chỉ để thấy ba nhà vô địch đang đứng đối mặt nhau. Cuối cùng, họ quyết định đưa tất cả đến Valhalla. Vậy là, những nhà vô địch của Đấu trường Heimdall vào mùa hè năm 2025 đã trở thành chiến binh của Valhalla."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Spanish translation loses semantic meaning

The Spanish translation for ITEM_DESCRIPTION_40100050 changed "traer de vuelta" to just "traer", removing the phrase "de vuelta" (back). The English source text explicitly states "bring back the strongest warrior", but the updated Spanish now says "traer al guerrero más fuerte" (bring the strongest warrior) instead of "traer de vuelta al guerrero más fuerte" (bring back the strongest warrior). This changes the meaning and loses the important context that the Valkyries are returning with the warrior, not just bringing them somewhere new.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants