Make it work for 32 bits platform with _FILE_OFFSET_BITS=64#12
Open
jief666 wants to merge 1 commit into
Open
Conversation
Author
|
After this one, if you're still interested in that project, I can submit few pull requests. |
vasi
pushed a commit
to vasi/libdmg-hfsplus
that referenced
this pull request
Sep 17, 2024
fix tests to be reproducible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a arithmetic problem on 32 bits platform when off_t is 64 bits.
Basically, we have to make sure to convert to 64 bits BEFORE the multiplication. Hence things like : ((off_t)extent->startBlock) * blockSize.