Initialize checksum structs to avoid inserting unused garbage padding#8
Merged
Merged
Conversation
for the fUDIFDataForkChecksum.data and fUDIFMasterChecksum.data structures, it appears as though only the first int is ever used for checksumming, but the other bytes are still written to the image. Initialize them so they don't contain random garbage.
|
Nice patch, unfortunately this project seem to be abandoned |
|
is this required for Merge Request #7? |
planetbeing
added a commit
that referenced
this pull request
Apr 11, 2015
Initialize checksum structs to avoid inserting unused garbage padding
1 task
laanwj
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Oct 14, 2019
9192ce5 depends: pull upstream libdmg-hfsplus changes (fanquake) 9b54f34 depends: latest config.guess & config.sub (fanquake) Pull request description: Pulled the first two commits off #16392, as they are standalone. Corys PRs (planetbeing/libdmg-hfsplus#7, planetbeing/libdmg-hfsplus#8) have been merged, and the author was active for a little while in 2017/18, so switch back to the upstream [`libdmg-hfsplus`](https://github.com/planetbeing/libdmg-hfsplus) repo. I've added the last of Corys patches into depends. [Switching back to upstream discussion](#16392 (comment)). Top commit has no ACKs. Tree-SHA512: a2313a731242251fef28921faf403c9bc354e6271cd7a26e9904ff5fae5766678136697fb5696006498a982ce319747b52b1df5151837388cda8f8145b45ab7c
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 15, 2019
9192ce5 depends: pull upstream libdmg-hfsplus changes (fanquake) 9b54f34 depends: latest config.guess & config.sub (fanquake) Pull request description: Pulled the first two commits off bitcoin#16392, as they are standalone. Corys PRs (planetbeing/libdmg-hfsplus#7, planetbeing/libdmg-hfsplus#8) have been merged, and the author was active for a little while in 2017/18, so switch back to the upstream [`libdmg-hfsplus`](https://github.com/planetbeing/libdmg-hfsplus) repo. I've added the last of Corys patches into depends. [Switching back to upstream discussion](bitcoin#16392 (comment)). Top commit has no ACKs. Tree-SHA512: a2313a731242251fef28921faf403c9bc354e6271cd7a26e9904ff5fae5766678136697fb5696006498a982ce319747b52b1df5151837388cda8f8145b45ab7c
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Apr 3, 2020
Summary: ``` Corys PRs (planetbeing/libdmg-hfsplus#7, planetbeing/libdmg-hfsplus#8) have been merged, and the author was active for a little while in 2017/18, so switch back to the upstream libdmg-hfsplus repo. I've added the last of Corys patches into depends. ``` Backport of core [[bitcoin/bitcoin#17057 | PR17057]]. Depends on D5653. The config.guess and config.sub scripts had no merge conflict. Test Plan: Run the OSX Gitian build. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5654
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Aug 17, 2020
Summary: ``` Corys PRs (planetbeing/libdmg-hfsplus#7, planetbeing/libdmg-hfsplus#8) have been merged, and the author was active for a little while in 2017/18, so switch back to the upstream libdmg-hfsplus repo. I've added the last of Corys patches into depends. ``` Backport of core [[bitcoin/bitcoin#17057 | PR17057]]. Depends on D5653. The config.guess and config.sub scripts had no merge conflict. Test Plan: Run the OSX Gitian build. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5654
vasi
pushed a commit
to vasi/libdmg-hfsplus
that referenced
this pull request
Aug 9, 2024
Re-land planetbeing#4, without addComment enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realize that @planetbeing is not really active or responsive here, but I'm submitting this in the event that someone who's googling this issue may stumble onto this PR.
for the fUDIFDataForkChecksum.data and fUDIFMasterChecksum.data structures, it
appears as though only the first int is ever used for checksumming, but the
other bytes are still written to the image. Initialize them so they don't
contain random garbage.
With this change, using dmg to compress an existing dmg produces consistent output.