Create local containerized keycloak docker example, update README#75
Merged
jloux-brapi merged 5 commits intobrapi-server-v2from Dec 16, 2024
Merged
Create local containerized keycloak docker example, update README#75jloux-brapi merged 5 commits intobrapi-server-v2from
jloux-brapi merged 5 commits intobrapi-server-v2from
Conversation
| version: '3' | ||
|
|
||
| services: | ||
| brapi-java-server-v1: |
There was a problem hiding this comment.
this service needs to stay
docker-compose.yaml
Outdated
| ports: | ||
| - "8080:8080" | ||
| # Expose DEBUG port | ||
| - "5005:5005" |
There was a problem hiding this comment.
8080 should not be exposed for the production server, all traffic should go through the rev-proxy service
5005 probably shouldn't be exposed... I'm not sure. It could be handy to have a public debug port open, but it would technically be unprotected access to live code ...
There was a problem hiding this comment.
We should see if there is a way to only expose 5005 through an ssh tunnel or something similar. I don't know how to do that off the top of my head, maybe a project for another day
Contributor
Author
There was a problem hiding this comment.
I removed these.
docker-compose-dev.yaml
Outdated
| ports: | ||
| - "5433:5432" | ||
| volumes: | ||
| brapi-data: |
There was a problem hiding this comment.
don't need this extra volumes section?
jloux-brapi
added a commit
to plantbreeding/brapi-Java-ProdServer
that referenced
this pull request
Dec 19, 2024
…ocker Create local containerized keycloak docker example, update README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite a few things done here:
docker-compose-dev.yamlset up for local development without authentication to allow developers to stand up the app in docker effortlesslydocker-compose-local-auth.yamlthat has a self-contained authentication service that connects to a user database that is also containerized. This should allow developers interested in standing up their own auth system with their brapi implementation to explore options.application.properties.templateto support a new property,security.issuer_url, which allows developers to set the issuer url for their generated tokens.Dockerfileto expose port 5005 for debugging the brapi app in a dockerized environment.