Skip to content

Update sdk#130

Merged
mzueva merged 1 commit intomainfrom
mzueva/update-sdk
Apr 24, 2026
Merged

Update sdk#130
mzueva merged 1 commit intomainfrom
mzueva/update-sdk

Conversation

@mzueva
Copy link
Copy Markdown
Contributor

@mzueva mzueva commented Apr 24, 2026

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several SDK and build tool dependencies, specifically targeting @milaboratories and @platforma-sdk packages, and includes a corresponding changeset. A review of the lockfile revealed a version mismatch between vitest and @vitest/coverage-istanbul, which could lead to inconsistent testing behavior.

Comment thread pnpm-lock.yaml
Comment on lines +7630 to +7631
'@vitest/coverage-istanbul': 4.1.5(vitest@3.2.4(@types/node@24.5.2)(lightningcss@1.32.0)(sass@1.89.2)(yaml@2.8.1))
vitest: 4.1.5(@types/node@24.5.2)(@vitest/coverage-istanbul@4.1.5)(vite@7.1.7(@types/node@24.5.2)(lightningcss@1.32.0)(sass@1.89.2)(yaml@2.8.1))
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a version mismatch in the resolution of vitest and its coverage plugin. While vitest is updated to 4.1.5, @vitest/coverage-istanbul is resolving its peer dependency to vitest@3.2.4. This inconsistency can lead to runtime errors or incorrect test coverage reporting, especially since vitest@4.1.5 now also lists the coverage plugin as a peer dependency, creating a mismatched circular reference. It is recommended to ensure all vitest related packages resolve to the same major version (4.x).

@mzueva mzueva added this pull request to the merge queue Apr 24, 2026
Merged via the queue into main with commit 28aeaf5 Apr 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant