Conversation
There was a problem hiding this comment.
Code Review
This pull request updates several SDK and build tool dependencies, specifically targeting @milaboratories and @platforma-sdk packages, and includes a corresponding changeset. A review of the lockfile revealed a version mismatch between vitest and @vitest/coverage-istanbul, which could lead to inconsistent testing behavior.
| '@vitest/coverage-istanbul': 4.1.5(vitest@3.2.4(@types/node@24.5.2)(lightningcss@1.32.0)(sass@1.89.2)(yaml@2.8.1)) | ||
| vitest: 4.1.5(@types/node@24.5.2)(@vitest/coverage-istanbul@4.1.5)(vite@7.1.7(@types/node@24.5.2)(lightningcss@1.32.0)(sass@1.89.2)(yaml@2.8.1)) |
There was a problem hiding this comment.
There is a version mismatch in the resolution of vitest and its coverage plugin. While vitest is updated to 4.1.5, @vitest/coverage-istanbul is resolving its peer dependency to vitest@3.2.4. This inconsistency can lead to runtime errors or incorrect test coverage reporting, especially since vitest@4.1.5 now also lists the coverage plugin as a peer dependency, creating a mismatched circular reference. It is recommended to ensure all vitest related packages resolve to the same major version (4.x).
No description provided.