Skip to content

Conversation

@mcollina
Copy link
Member

@mcollina mcollina commented Sep 8, 2025

Summary

  • Update Express dependency from v4.19.2 to v5.0.0
  • Fix route parameter compatibility for Express v5 by replacing optional parameter syntax
  • Refactor batch endpoint to use separate routes instead of optional parameters
  • All tests passing with Express v5

Changes

  • package.json: Update Express from ^4.19.2 to ^5.0.0
  • examples/express-benchmark-app.js:
    • Replace /batch/:type/:count? route with separate routes for Express v5 compatibility
    • Add handleBatchRequest helper function to handle both /batch/:type/:count and /batch/:type routes
    • Fix linting issues (space before function parentheses)

Test plan

  • All existing tests pass
  • Benchmark app starts successfully with Express v5
  • Both /batch/:type and /batch/:type/:count endpoints work correctly
  • No breaking changes to API functionality

This update brings the project up to the latest major version of Express while maintaining backward compatibility for all existing functionality.

- Update Express dependency from ^4.19.2 to ^5.0.0
- Replace optional route parameter syntax (:count?) with separate routes for Express v5 compatibility
- Refactor batch endpoint to use handleBatchRequest helper function
- Add dedicated routes for /batch/:type/:count and /batch/:type
- All tests passing with Express v5
@mcollina mcollina merged commit 6bf9813 into main Sep 8, 2025
6 checks passed
@mcollina mcollina deleted the update-express-v5 branch September 8, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants