More flexible url/path rewriting #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qard
force-pushed
the
more-flexible-url-path-rewriting
branch
from
66fa153 to
ec5c1bb
Compare
ShogunPanda
previously approved these changes
Oct 22, 2025
Qard
force-pushed
the
more-flexible-url-path-rewriting
branch
from
ec5c1bb to
d4911fb
Compare
Qard
force-pushed
the
more-flexible-url-path-rewriting
branch
from
d4911fb to
690d0d2
Compare
|
|
||
| // If the result doesn't have a scheme/authority but the original did, | ||
| // preserve the original scheme and authority | ||
| let final_uri = if new_uri.scheme().is_none() && parts.uri.scheme().is_some() { |
There was a problem hiding this comment.
I'd write it as follow to access parts.uri.scheme() once - but probably it's not relevant
let final_uri = if new_uri.scheme().is_none() {
if let Some(scheme) = parts.uri.scheme() {
simone-sanfratello
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the http-rewriter to support both path-only rewriting and full URL rewriting, enabling backwards compatibility with how php-node presently works.
Depends on platformatic/http-handler#39