fix: Add integration tests for OpenTelemetry compatibility and remove… #184
+138
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monwolf
force-pushed
the
fix/otel-circular-import
branch
3 times, most recently
from
b7b0341 to
ab07580
Compare
mcollina
requested changes
Dec 17, 2025
src/diagnostic.ts
Outdated
| initializeChannels() | ||
| return _producerSendsChannel[prop as keyof typeof _producerSendsChannel] | ||
| } | ||
| }) |
Member
There was a problem hiding this comment.
Unfortunately using proxy would slow this library down massively, we should identify a different approach.
Author
There was a problem hiding this comment.
I think removing the circular export should be enough let me double check it
Author
There was a problem hiding this comment.
@mcollina I reverted this file. And it's working also.
Signed-off-by: Bernat Mut <bernat.mut@aireuropa.com>
monwolf
force-pushed
the
fix/otel-circular-import
branch
from
ab07580 to
6e13771
Compare
mcollina
requested changes
Dec 19, 2025
| 'protocol/index.ts should not contain circular self-reference') | ||
| }) | ||
|
|
||
| it('should use lazy initialization for diagnostic channels', async () => { |
Member
There was a problem hiding this comment.
I think this should be removed as well
Comment on lines
+15
to
+16
| const __filename = fileURLToPath(import.meta.url) | ||
| const __dirname = dirname(__filename) |
Member
There was a problem hiding this comment.
These are not needed anymore, use import.meta.dirname and import.meta.filename
| describe('OpenTelemetry Integration', () => { | ||
| it('should import library without hanging when OTEL hook is active', async () => { | ||
| // Create a minimal test script that imports the library | ||
| const { pathToFileURL } = await import('node:url') |
| ` | ||
|
|
||
| // Write test script to a temporary file | ||
| const { writeFileSync, unlinkSync, mkdtempSync } = await import('node:fs') |
|
|
||
| // Write test script to a temporary file | ||
| const { writeFileSync, unlinkSync, mkdtempSync } = await import('node:fs') | ||
| const { tmpdir } = await import('node:os') |
| } | ||
| }) | ||
|
|
||
| it('should not have circular self-import in protocol/index.ts', async () => { |
Member
There was a problem hiding this comment.
I think this is not a good test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… circular imports
should fix #181