Skip to content

Improve safety and test coverage #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollina merged 3 commits into from
May 23, 2025
Merged

Improve safety and test coverage #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3de659
Improve safety and test coverage
Qard May 23, 2025
e8b3548
Improve exceptions
Qard May 23, 2025
0b14d3c
Skip cargo test on Linux for now...
Qard May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,12 @@ jobs:
- name: List packages
run: ls -R ./npm
shell: bash
# TODO: This should be moved to the test jobs, but needs build deps
# for ext-php-rs to build correctly, including PHP cli
- name: Test crates
if: ${{ contains(matrix.target, 'linux') }}
shell: bash
run: cargo test
- name: Upload target-specific package for ${{ matrix.settings.target }}
uses: actions/upload-artifact@v4
with:
Expand Down Expand Up @@ -313,6 +319,10 @@ jobs:
- name: List packages
run: ls -R ./npm
shell: bash
- name: Give GitHub Actions access to ext-php-rs
uses: webfactory/ssh-agent@v0.5.4
with:
ssh-private-key: ${{ secrets.SECRET_REPO_DEPLOY_KEY }}
- name: Test bindings
run: pnpm test

Expand Down Expand Up @@ -381,7 +391,7 @@ jobs:
- name: List packages
run: ls -R ./npm
shell: bash
- name: Test bindings
- name: Test crates and bindings
uses: addnab/docker-run-action@v3
with:
image: ${{ steps.docker.outputs.IMAGE }}
Expand Down
14 changes: 6 additions & 8 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,11 @@ jobs:
- name: Cargo fmt
run: cargo fmt -- --check

# TODO: Clippy yells a lot. Need to clean things up before turning it on.

# Clippy needs access to install ext-php-rs
# - name: Give GitHub Actions access to ext-php-rs
# uses: webfactory/ssh-agent@v0.5.4
# with:
# ssh-private-key: ${{ secrets.SECRET_REPO_DEPLOY_KEY }}
- name: Give GitHub Actions access to ext-php-rs
uses: webfactory/ssh-agent@v0.5.4
with:
ssh-private-key: ${{ secrets.SECRET_REPO_DEPLOY_KEY }}

# - name: Clippy
# run: cargo clippy
- name: Clippy
run: cargo clippy
Loading
Loading