Fix shutdown cleanup #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qard
force-pushed
the
fix-shutdown-cleanup
branch
3 times, most recently
from
7637674 to
0602858
Compare
Qard
force-pushed
the
fix-shutdown-cleanup
branch
from
0602858 to
522ee4e
Compare
Qard
force-pushed
the
fix-shutdown-cleanup
branch
2 times, most recently
from
9f66788 to
981d29f
Compare
Qard
force-pushed
the
fix-shutdown-cleanup
branch
3 times, most recently
from
202438e to
69fc1c6
Compare
Qard
force-pushed
the
fix-shutdown-cleanup
branch
from
69fc1c6 to
4f8da04
Compare
Qard
force-pushed
the
fix-shutdown-cleanup
branch
4 times, most recently
from
9146623 to
541436c
Compare
This makes it so each instance of Embed holds an Arc so that the underlying SAPI may be dropped when there are no more Embeds. A Weak is held to attempt to upgrade an existing SAPI for any future Embed constructions, but will construct a new SAPI any time one is unavailable via the Weak.
Qard
force-pushed
the
fix-shutdown-cleanup
branch
from
541436c to
7eff1fc
Compare
mcollina
reviewed
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on this here...will reland when I get it working.