Skip to content

Fix macOS code-signing #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Qard merged 1 commit into from
Sep 30, 2025
Merged

Fix macOS code-signing #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion fix-python-soname.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,26 @@ async function runSonameFixer() {
});

// Run the WASI module
process.exit(wasi.start(instance))
const exitCode = wasi.start(instance)
if (exitCode !== 0) {
console.error(`Error: soname fixer exited with code ${exitCode}`)
process.exit(exitCode)
}

// On macOS, re-sign the binary after patching
if (platform === 'darwin') {
console.log('Re-signing binary after patching...')
const { execSync } = require('child_process')
try {
execSync(`codesign --force --sign - "${nodeFilePath}"`, { stdio: 'inherit' })
console.log('Binary re-signed successfully')
} catch (error) {
console.error('Warning: Failed to re-sign binary:', error.message)
// Don't fail the install if codesign fails - the binary might still work
}
}

process.exit(0)
} catch (error) {
console.error('Error: Failed to run soname fixer:', error.message)
process.exit(1) // Fail hard when installed as dependency
Expand Down
Loading