Skip to content

Follow changes to http-handler and http-rewriter #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Qard merged 1 commit into from
Oct 22, 2025
Merged

Follow changes to http-handler and http-rewriter #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 25 additions & 16 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ crate-type = ["cdylib"]
async-trait = "0.1.88"
bytes = "1.10.1"
http-handler = { git = "https://github.com/platformatic/http-handler" }
# http-handler = { path = "../http-handler" }
http-rewriter = { git = "https://github.com/platformatic/http-rewriter" }
# http-rewriter = { path = "../http-rewriter" }
# Default enable napi4 feature, see https://nodejs.org/api/n-api.html#node-api-version-matrix
napi = { version = "3", default-features = false, features = ["napi4", "tokio_rt", "async"], optional = true }
napi-derive = { version = "3", optional = true }
Expand Down
9 changes: 3 additions & 6 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,10 +233,9 @@ impl PythonHandler {
/// ```
#[napi]
pub async fn handle_request(&self, request: &NapiRequest) -> Result<NapiResponse> {
use std::ops::Deref;
let response = self
.asgi
.handle(request.deref().clone())
.handle(request.clone().into_inner())
.await
.map_err(|e| Error::from_reason(e.to_string()))?;
Ok(response.into())
Expand All @@ -246,11 +245,10 @@ impl PythonHandler {
// request: &NapiRequest,
// signal: Option<AbortSignal>,
// ) -> AsyncTask<PythonRequestTask> {
// use std::ops::Deref;
// AsyncTask::with_optional_signal(
// PythonRequestTask {
// asgi: self.asgi.clone(),
// request: request.deref().clone(),
// request: request.clone().into_inner(),
// },
// signal,
// )
Expand All @@ -276,10 +274,9 @@ impl PythonHandler {
/// ```
#[napi]
pub fn handle_request_sync(&self, request: &NapiRequest) -> Result<NapiResponse> {
use std::ops::Deref;
let mut task = PythonRequestTask {
asgi: self.asgi.clone(),
request: request.deref().clone(),
request: request.clone().into_inner(),
};

task.compute().map(Into::<NapiResponse>::into)
Expand Down
Loading