Actually fix max age #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <hello@matteocollina.com>
ivan-tymoshenko
approved these changes
May 8, 2025
Member
ivan-tymoshenko
left a comment
ivan-tymoshenko
left a comment
There was a problem hiding this comment.
I see it adds a vary property, but not sure how does it fix maxage. Anyway lgtm
Member
Author
|
@ivan-tymoshenko I've updated the shared test from undici. It now requires a https://github.com/platformatic/undici-cache-memory/pull/14/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R175 does the fix for max-age. |
Member
|
oh, it copies an object in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes some parts of nodejs/undici#4198.