Skip to content

Conversation

@gvechini
Copy link
Contributor

Adicionando o componente data-split e suas adaptações nos componentes da platIA.

Gabriela Correia Vechini added 2 commits July 21, 2022 18:02
@dfvneto
Copy link
Contributor

dfvneto commented Jul 25, 2022

Tem que revisar também a parte de cluster pois tem que saber se esse componente vai vim instalado de forma padrão ou não. Precisa ver se precisa ser atualizada a imagem de experimento e tarefas para absorver esse componente novo

Copy link

@CommanderErika CommanderErika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Olhei as mudanças e aparenta estar tudo ok. Só não vi os arquivos relacionados a config e ymal.

@gvechini gvechini requested a review from GabrielTalasso July 26, 2022 19:22
Copy link
Contributor

@gregorylira gregorylira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pelo que eu vi esta tudo certo, só não vi muito os arquivos yml.

@gvechini gvechini requested a review from DayvisonGomes July 27, 2022 19:11
@gvechini
Copy link
Contributor Author

Os arquivos que me preocupam são os de teste do data split e rf classification.

Copy link

@GabrielTalasso GabrielTalasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por aqui parece tudo certo.

"\n",
"artifacts = {\n",
" \"columns\": columns,\n",
" \"new_column_name\" = new_column_name,\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aqui não seria : tbm ?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants