Add global diagnostic source attribution for validation output#239
Draft
shahabdsh wants to merge 1 commit intoplayer-ui:mainfrom
Draft
Add global diagnostic source attribution for validation output#239shahabdsh wants to merge 1 commit intoplayer-ui:mainfrom
shahabdsh wants to merge 1 commit intoplayer-ui:mainfrom
Conversation
Wrap validation hooks to stamp plugin names onto diagnostics and add parser-source labeling so consumers can trace validation origins without per-plugin updates. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlayerLanguageServiceby wrappingvalidateandonValidateEndhook taps so diagnostics inherit the emitting plugin name whensourceis missingjson-parse) and fallback normalization so diagnostics always includesourceeven when plugins return rebuilt diagnostic arraysjson-language-serviceandcomplexity-check-pluginto assert source metadata is preserved for validate-phase and onValidateEnd diagnosticsTest plan
pnpm vitest run "language/json-language-service/src/__tests__/service.test.ts" "language/complexity-check-plugin/src/__tests__/complexity-check-plugin.test.ts"Made with Cursor