Skip to content

Bugfix/long lists#36

Merged
KetanReddy merged 3 commits intomainfrom
bugfix/long-lists
Feb 2, 2023
Merged

Bugfix/long lists#36
KetanReddy merged 3 commits intomainfrom
bugfix/long-lists

Conversation

@KetanReddy
Copy link
Copy Markdown
Member

@KetanReddy KetanReddy commented Jan 30, 2023

Closes #35

Release Notes

Fixes issues when long constant lists were indexed to create a union.

Version

Published prerelease version: 0.3.1-next.0

Changelog

Release Notes

Bugfix/long lists (#36)

Fixes issues when long constant lists were indexed to create a union.


🐛 Bug Fix

Authors: 1

@KetanReddy KetanReddy added the patch Increment the patch version when merged label Jan 30, 2023
@KetanReddy KetanReddy requested a review from adierkens as a code owner January 30, 2023 23:13
@KetanReddy
Copy link
Copy Markdown
Member Author

The 1 in the typeToTypeNode call is a parameter to disable truncation

image

effectiveType,
node,
undefined
1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the enum here?

NodeBuilderFlags.NoTruncation

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good call.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 31, 2023

Codecov Report

Base: 53.85% // Head: 53.33% // Decreases project coverage by -0.53% ⚠️

Coverage data is based on head (ef07253) compared to base (7be2052).
Patch coverage: 5.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   53.85%   53.33%   -0.53%     
==========================================
  Files          53       56       +3     
  Lines        2954     2996      +42     
  Branches      876      890      +14     
==========================================
+ Hits         1591     1598       +7     
- Misses       1093     1124      +31     
- Partials      270      274       +4     
Impacted Files Coverage Δ
cli/src/commands/xlr/compile.ts 0.00% <0.00%> (ø)
cli/src/utils/xlr/consts.ts 0.00% <0.00%> (ø)
cli/src/utils/xlr/visitors/file.ts 0.00% <0.00%> (ø)
cli/src/utils/xlr/visitors/plugin.ts 0.00% <0.00%> (ø)
xlr/converters/src/ts-to-xlr.ts 72.19% <100.00%> (+0.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KetanReddy KetanReddy merged commit 3ecf732 into main Feb 2, 2023
@KetanReddy KetanReddy deleted the bugfix/long-lists branch February 2, 2023 21:20
@intuit-svc intuit-svc mentioned this pull request Oct 18, 2023
@intuit-svc intuit-svc mentioned this pull request Nov 6, 2023
6 tasks
@intuit-svc intuit-svc mentioned this pull request Nov 15, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error Thrown when Indexing Long Lists

3 participants