Skip to content

Comments

Updating Feature/drag and drop branch with latest.#44

Merged
KetanReddy merged 3 commits intoplayer-ui:feature/drag-and-dropfrom
sandrews06:feature/drag-and-drop
Feb 7, 2023
Merged

Updating Feature/drag and drop branch with latest.#44
KetanReddy merged 3 commits intoplayer-ui:feature/drag-and-dropfrom
sandrews06:feature/drag-and-drop

Conversation

@sandrews06
Copy link

  • Updating feature/drag-and-drop branch with the latest from main
  • added test-helper for xlr / utils.
  • all tests still run green.
  • verified drag and drop app still functions as expected.

neveena and others added 3 commits February 6, 2023 13:19
Adds support for the JSDOC `@meta` tag to allow arbitrary metadata information to be serialized with an XLR. 

---------

Co-authored-by: Neveena <neveena_ferrao@intuit.com>
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 53.44% // Head: 54.83% // Increases project coverage by +1.39% 🎉

Coverage data is based on head (1a61a36) compared to base (3ec921c).
Patch coverage: 71.42% of modified lines in pull request are covered.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feature/drag-and-drop      #44      +/-   ##
=========================================================
+ Coverage                  53.44%   54.83%   +1.39%     
=========================================================
  Files                         64       64              
  Lines                       3312     3319       +7     
  Branches                     971      975       +4     
=========================================================
+ Hits                        1770     1820      +50     
+ Misses                      1246     1174      -72     
- Partials                     296      325      +29     
Impacted Files Coverage Δ
xlr/utils/src/annotations.ts 51.02% <71.42%> (+51.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KetanReddy KetanReddy merged commit d52ac66 into player-ui:feature/drag-and-drop Feb 7, 2023
@sandrews06 sandrews06 deleted the feature/drag-and-drop branch February 7, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants