feat: added ability to add player plugins that don't have a manifest in dnd library#47
Merged
KetanReddy merged 3 commits intoplayer-ui:feature/drag-and-dropfrom Feb 27, 2023
Conversation
Codecov ReportBase: 55.08% // Head: 55.10% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feature/drag-and-drop #47 +/- ##
=========================================================
+ Coverage 55.08% 55.10% +0.01%
=========================================================
Files 64 64
Lines 3342 3343 +1
Branches 985 986 +1
=========================================================
+ Hits 1841 1842 +1
Misses 1176 1176
Partials 325 325
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Currently any player plugin added needs a manifest as well. This should only be for assets that need to be dragged and dropped.
What Changed