Open
Conversation
There was a problem hiding this comment.
Using a previous django version isn't exactly an exceptional situation, so rather than handling an exception here you ought to be using getattr.
Contributor
There was a problem hiding this comment.
Also missing "pass" or something so this isn't a hanging block
There was a problem hiding this comment.
Pass is only used to mark an empty block as being empty. This isn't an empty block.
Contributor
There was a problem hiding this comment.
Oh it got interrupted by these comments
|
Please indicate what has changed in the commit message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.