Upgrade Hibernate to 5.x

[asolntsev]

Currently Play1 uses Hibernate 4.2.19 which is pretty old.
Need to upgrade to Hibernate 5.2.5 (or later).

See https://play.lighthouseapp.com/projects/57987-play-framework/tickets/1818-hibernate-need-to-be-updated-to-v435#ticket-1818-6

[tomparle]

Thank you Andrei for this (among several others) improvement !

[asolntsev]

@tomparle @xael-fry
Hi! Can you help me with Hibernate 5?

Can anyone tell why the third line saves BLUP, thought I didn't call any save method?

Horse existing = Horse.all().first();   // existing.bulp == null
existing.setBlup(new BLUP());
em().flush();   // why it executes "insert into BLUP (id, total) values (null, ?)" ???

[asolntsev]

@tomparle @xael-fry
I found the answer. We just have to add the following property: properties.put("org.hibernate.flushMode", FlushMode.MANUAL);

to avoid auto-saving of dirty (unsaved) objects.

[flybyray]

@asolntsev maybe it should be fixed in current play to?

https://github.com/playframework/play1/blob/master/framework/src/play/db/jpa/JPA.java#L364

The key-pattern for properties should honor org.hibernate
https://github.com/playframework/play1/blob/master/framework/src/play/db/Configuration.java#L88

thx

[flybyray]

@xael-fry @asolntsev

I found the answer. We just have to add the following property: properties.put("org.hibernate.flushMode", FlushMode.MANUAL);

It should have a ticket in lighthouse and should be fixed for 1.4.x too. The current AUTO-FlushMode has unpredictable consequences.

[asolntsev]

@flybyray @tomparle @xael-fry Actually I am not sure about my previous answer. Probably the default value AUTO of setting "org.hibernate.flushMode" is good.

Alex, do you know why HibernateInterceptor is needed? Can we remove it? Without it, the failing test JPASave becomes green.

[flybyray]

@asolntsev HibernateInterceptor is some essential part of Play! JPA improvment. I think you will need it even in Hibernate 5+. Please look for the willBeSaved variable and its usage saveAndCascade.

Maybe you should look into framework/patches/hibernate-4.2.19-patch-play.patch.patch too to find an answer for failing tests.

[xael-fry]

I agree with @flybyray we should keep HibernateInterceptor