Skip to content

Enable cross-chain token transfers#107

Merged
vayesy merged 5 commits intodevfrom
feature/orml-xtokens
Sep 26, 2022
Merged

Enable cross-chain token transfers#107
vayesy merged 5 commits intodevfrom
feature/orml-xtokens

Conversation

@vayesy
Copy link
Member

@vayesy vayesy commented Sep 22, 2022

  • Starts using ORML asset-registry to store foreign tokens information
  • Setups XCM pallets and modules to communicate between parachains
  • Adds ORML xtokens pallet for cross-chain token transfers
  • Includes tokens information into new chainspec files
  • Renames parachain binary subzero-collator -> subzero
  • Updates docker-compose for local relay/parachain setup

@vayesy vayesy requested review from 2075 and vovacha September 22, 2022 10:41
@vayesy vayesy self-assigned this Sep 22, 2022
@vayesy vayesy force-pushed the feature/orml-xtokens branch 4 times, most recently from b743e99 to 793eea1 Compare September 22, 2022 14:31
@vayesy vayesy force-pushed the feature/orml-xtokens branch from 793eea1 to dda5b3f Compare September 22, 2022 14:32
@vayesy vayesy marked this pull request as ready for review September 22, 2022 14:38
// GAME:DOT = 6:1
TokenSymbol::GAME => (cent(GAME) * 18 / 1000),
// PLAY:DOT = 6:1
TokenSymbol::PLAY => (cent(PLAY) * 18 / 1000),
Copy link
Contributor

@vovacha vovacha Sep 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@2075 could you review this? It's the initial price ratio.

PLAY probably 6:1 agree based on the current DOT price.
But as for GAME and ZERO, I'm not so sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, how would price discovery via acala dex work? alternative could be through fx provider via ocw

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Price discovery is separate piece of logic.
Here proportions determined to know amount of fee to pay per cross-chain transactions for each known token.
In case we would need to change those, should do runtime upgrade - same approach as for other parachains.

Copy link
Contributor

@vovacha vovacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

Copy link
Member

@2075 2075 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, smol questions for you @vasylenko-yevhen

// GAME:DOT = 6:1
TokenSymbol::GAME => (cent(GAME) * 18 / 1000),
// PLAY:DOT = 6:1
TokenSymbol::PLAY => (cent(PLAY) * 18 / 1000),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, how would price discovery via acala dex work? alternative could be through fx provider via ocw

…d standalone chain to work with new currency interface.
@vayesy vayesy merged commit d4557e9 into dev Sep 26, 2022
@vayesy vayesy deleted the feature/orml-xtokens branch September 26, 2022 19:17
@vayesy vayesy linked an issue Oct 5, 2022 that may be closed by this pull request
@vayesy vayesy mentioned this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate ORML xtokens into parachain runtime

3 participants