Merged
Conversation
Member
|
@bidzyyys thanks for your review from our entire team! As for the Sudo - we only use it now for faster development but plan to get rid in favor of other approaches, like councils with next versions. By the time, when we will be ready for live version, no Sudo will be present. We created issue #193 to fix review items and will start working on it in nearest future. |
6 tasks
vayesy
reviewed
Oct 28, 2022
| primitives = { version = "2.0.0", package = "zero-primitives", default-features = false, path = "../../../modules/primitives" } | ||
|
|
||
| # ORML | ||
| # SBP-M2 review: why you use your copy of orml instead of following main implementation? |
Member
There was a problem hiding this comment.
It's actually original version of ORML without any modification. We just use it as a submodule, but github link should also work fine, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.