Conversation
2 tasks
FiberMan
force-pushed
the
227-add-battlepass-pallet
branch
from
0a51077 to
a188e25
Compare
vovacha
suggested changes
Dec 22, 2022
Contributor
vovacha
left a comment
vovacha
left a comment
There was a problem hiding this comment.
LGTM, but building with benchmarks doesn't work (subzero-dev). Can you check it once more?
cargo build --release --features runtime-benchmarks
| "gamedao-control/runtime-benchmarks", | ||
| "gamedao-flow/runtime-benchmarks", | ||
| "gamedao-signal/runtime-benchmarks", | ||
| "gamedao-battlepass/runtime-benchmarks", |
Contributor
There was a problem hiding this comment.
There are no benchmarks defined for this pallet.
Member
Author
There was a problem hiding this comment.
Not yet, will add benchmarks in separate PR.
bin/alphaville/runtime/src/lib.rs
Outdated
| type StringLimit = StringLimit; | ||
| type SymbolLimit = ConstU32<100>; | ||
| type PartsLimit = ConstU32<25>; | ||
| type MaxResourcesOnMint = ConstU32<100>; |
Contributor
There was a problem hiding this comment.
We can reuse the same constants for rmrk_core and this pallet with the parameter_types! macro.
FiberMan
force-pushed
the
227-add-battlepass-pallet
branch
from
0883d46 to
9534d2b
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.