pip_library: test for presence of --system option before invoking pip #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of pip provided by `python3-pip` in Debian 12 will drop the custom `--system` option - passing it results in pip exiting with an error. Rather than always passing `--system` if the host OS is Debian-like, test whether the configured pip tool implements a `--system` option, and if so, pass it to the real pip invocation. Fixes please-build#81.
Contributor
|
Makes sense, but weren't we getting rid of the CLI invocation in this repo in favour of a custom tool? @samwestmoreland ? |
Contributor
|
Yes, we will ideally be moving to use the wheel resolver tool in v2 of the plugin. But definitely think it makes sense to have this in the meantime. Thanks, Chris! |
samwestmoreland
approved these changes
Nov 14, 2022
This was referenced Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of pip provided by
python3-pipin Debian 12 will drop the custom--systemoption - passing it results in pip exiting with an error. Rather than always passing--systemif the host OS is Debian-like, test whether the configured pip tool implements a--systemoption, and if so, pass it to the real pip invocation.Fixes #81.