Skip to content

Conversation

@izphi78
Copy link
Contributor

@izphi78 izphi78 commented Nov 26, 2025

Allow users to specify custom GPU devices and driver capabilities
for NVIDIA GPU workloads instead of using hardcoded defaults.

Changes:

  • Add optional pms.gpu.nvidia.devices field (default: "all")
    Supports GPU indices, UUIDs, or "all" for all GPUs
  • Add optional pms.gpu.nvidia.capabilities field
    (default: "compute,video,utility")
  • Add documentation links to NVIDIA Container Toolkit docs
  • Use Helm default function for cleaner template syntax

Users can now specify specific GPUs (e.g., "0,1" or by UUID) and
customize driver capabilities (compute, video, utility, graphics, etc.)
according to their workload requirements.

References:

Allow users to specify custom GPU devices and driver capabilities
for NVIDIA GPU workloads instead of using hardcoded defaults.

Changes:
- Add optional `pms.gpu.nvidia.devices` field (default: "all")
  Supports GPU indices, UUIDs, or "all" for all GPUs
- Add optional `pms.gpu.nvidia.capabilities` field
  (default: "compute,video,utility")
- Add documentation links to NVIDIA Container Toolkit docs
- Use Helm default function for cleaner template syntax

Users can now specify specific GPUs (e.g., "0,1" or by UUID) and
customize driver capabilities (compute, video, utility, graphics, etc.)
according to their workload requirements.

References:
- GPU enumeration: https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/docker-specialized.html#gpu-enumeration
- Driver capabilities: https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/docker-specialized.html#driver-capabilities
@izphi78 izphi78 requested a review from a team as a code owner November 26, 2025 11:13
@izphi78 izphi78 marked this pull request as draft November 26, 2025 11:27
Document new configurable fields for NVIDIA GPU support:
- pms.gpu.nvidia.devices: GPU device selection
- pms.gpu.nvidia.capabilities: Driver capabilities configuration

Include links to official NVIDIA Container Toolkit documentation
for GPU enumeration and driver capabilities.

Bump chart version.
@izphi78 izphi78 marked this pull request as ready for review November 26, 2025 11:33
Copy link
Member

@cilindrox cilindrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @izphi78

Just a small nit regarding the versioning, this should be a minor bump to v1.3.0.

izphi78 and others added 3 commits November 27, 2025 11:47
Co-authored-by: Gaston Festari <cilindrox@gmail.com>
Co-authored-by: Gaston Festari <cilindrox@gmail.com>
Co-authored-by: Gaston Festari <cilindrox@gmail.com>
@izphi78
Copy link
Contributor Author

izphi78 commented Nov 27, 2025

Thank you for the quick response ! :) Do I need to sign my commits ? If so, shall I open a new PR or force push the new commits ?

Copy link
Member

@cilindrox cilindrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @izphi78

no need to sign them - I'll squash these and they'll get signed through GH's gui.

a1gemmel and others added 2 commits November 27, 2025 16:18
Rename claimSecret.value -> claimSecret.key conditional check in the `statefulset.yaml` template.
Signed-off-by: Gaston Festari <cilindrox@gmail.com>
@cilindrox cilindrox self-assigned this Nov 27, 2025
@cilindrox cilindrox changed the title Add support for custom NVIDIA GPU device selection and capabilities feat: add support for custom NVIDIA GPU device selection and capabilities Nov 27, 2025
@cilindrox cilindrox merged commit 735d2fb into plexinc:master Nov 27, 2025
2 checks passed
@cilindrox
Copy link
Member

This has shipped on v1.3.0 - thanks @izphi78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants