pass predictableActionArguments to the xstate FSM#14
Merged
clord merged 1 commit intoMar 8, 2023
Merged
Conversation
Member
|
No build commits yet, ci is still young here. Feel free to push dist up too, but I can do it for next release, too. |
Contributor
Author
|
I think at this point we best do the build separate as I've noticed that building the artifacts in this PR includes a few changes from prior modifications that haven't been built yet and I'd love to keep this to a simple reverse-able commit :) Does that seem fair? |
Member
|
yep for sure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of smaller changes in the PR:
src/tailwind.cssfile toidentity-obj-proxyto get the Jest test suite to workxstateand@xstate/reactsince the current versions don't seem to support the type definitions forpredictableActionArgumentspredictableActionArgumentsin to the Xstate machinesI've not updated the build artifacts in this PR as I recon those are compiled in separate build commits?