Backstory: the existing Galata scaffold (`ui-tests/extension.spec.ts`) only smoke-tested that the extension activates and the sidebar opens. Five UX-persona agents brainstormed flows; this commit lands a synthesis of the highest-signal ones across four new spec files. The suite stays **developer-triggered**: it's not wired into `.github/workflows/build.yml` because each run boots a real JL process and Chromium. The intent is to reach for `cd ui-tests && jlpm test` before merging PRs that touch one of the covered surfaces. What landed: * `chat-sidebar.spec.ts` (6 tests) — footer icons + labels, gear-icon title, prefix popover via typed `/`, slash-button toggle, workspace file picker open + close, and the plmbr#262 regression (Escape from the picker search input). * `notebook-toolbar.spec.ts` (5 tests) — toolbar button renders, popover structure, the plmbr#231 regression (textarea focus on open), submit gating, Escape + outside-click dismissal. * `cell-output.spec.ts` (3 tests) — hover toolbar renders Explain + Ask on clean cells, Troubleshoot only on errored cells, click activates the hovered cell. * `launcher.spec.ts` (1 test, currently `.fixme`) — pins the plmbr#260/plmbr#268 regression: tiles must add/dispose dynamically when capabilities flip. Marked `.fixme` until PR plmbr#268 merges since main still has the bug; flipping to `test()` once the fix lands turns this into the regression guard the PR description promised. * `helpers.ts` — minimal shared fixtures (`openChatSidebar`, `readNbiConfig`) so each spec stays tight. Harness fixes the scaffold needed to actually run: * `playwright.config.ts`: Galata 5 doesn't re-export `defineConfig`; import from `@playwright/test` directly. Removed the `appPath` use option that didn't typecheck without Galata's extended config. * `jupyter_server_test_config.py`: call `configure_jupyter_server(c)` from `jupyterlab.galata` so Galata's helper hooks land. Without it the harness raised "Failed to activate galata extension" on first navigation. * `package.json`: new `test:list` script for discovering what's available without running anything. Suite runs in ~30s on a warm cache; 16/17 pass against current main, 1 intentionally skipped (the launcher fixme).

Clicking NBI notebook toolbar button shows dialog but doesn't focus on input #231

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions