fix plugin name on settings row#280
Merged
Merged
Conversation
Collaborator
Author
|
I wonder this was due to Claude Code version. mine is: |
Collaborator
Author
|
@pjdoland can you review these changes? |
pjdoland
approved these changes
May 17, 2026
Collaborator
There was a problem hiding this comment.
Looks good. The version-skew hypothesis tracks; falling back to id is a clean way to handle both Claude CLI shapes without changing behavior when name is present. Threading the fallback through all four call sites (handlers, mapping, and rendering) is the right call so any path through the panel renders the same label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All plugins on Plugin settings tab were showing as unnamed