Skip to content

allow configuration in the home directory#899

Merged
edublancas merged 13 commits into
ploomber:masterfrom
marshallwhiteorg:user-config
Oct 10, 2023
Merged

allow configuration in the home directory#899
edublancas merged 13 commits into
ploomber:masterfrom
marshallwhiteorg:user-config

Conversation

@marshallwhiteorg
Copy link
Copy Markdown

@marshallwhiteorg marshallwhiteorg commented Sep 27, 2023

Describe your changes

Issue number

Closes #880

Checklist before requesting a review


📚 Documentation preview 📚: https://jupysql--899.org.readthedocs.build/en/899/

@tonykploomber
Copy link
Copy Markdown

LMK if it's ready to review

@marshallwhiteorg marshallwhiteorg marked this pull request as ready for review October 3, 2023 06:15
@marshallwhiteorg
Copy link
Copy Markdown
Author

@tonykploomber It's ready for review

Comment thread doc/jupyterlab/sharing.md
Comment thread src/tests/test_config.py Outdated
Comment thread src/tests/test_config.py Outdated
Comment thread doc/api/configuration.md Outdated
Comment thread doc/api/configuration.md Outdated
Comment thread src/tests/test_config.py Outdated
Comment thread src/tests/test_config.py Outdated
@marshallwhiteorg
Copy link
Copy Markdown
Author

Okay it's ready for review again

edublancas
edublancas previously approved these changes Oct 9, 2023
@edublancas edublancas requested a review from neelasha23 October 9, 2023 22:20
@edublancas
Copy link
Copy Markdown

lgtm. @neelasha23: can you run some manual tests and check that everything works as documented?

@marshallwhiteorg: some feedback, you can use monkeypatch from pytest as well, you used patch (which is fine), but it's better to stick with monkeypatch since we use that in other tests.

@edublancas edublancas changed the title #880 User-level config allow configuration in the home directory Oct 9, 2023
@neelasha23
Copy link
Copy Markdown

lgtm overall!

Just one clarification. what about the case where directory contains pyproject.toml file but it doesn't have the header [tool.jupysql.SqlMagic]. Should it look in ~/.jupysql/config? Is this out of scope?

@edublancas @marshallwhiteorg

@edublancas
Copy link
Copy Markdown

@neelasha23 good observations. I'll merge this now but open an issue so we can tackle it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SqlMagic Config File Locations

4 participants