Core Components Integration #131
Conversation
| end | ||
|
|
||
|
|
||
| const _reserwed_words = Set( |
There was a problem hiding this comment.
| const _reserwed_words = Set( | |
| const _reserved_words = Set( |
gen_resources/generator/deploy.jl
Outdated
| ) | ||
| end | ||
| end | ||
| function upload_to_resleases(repo_name, tag, tarball_path; attempts = 3) |
There was a problem hiding this comment.
| function upload_to_resleases(repo_name, tag, tarball_path; attempts = 3) | |
| function upload_to_releases(repo_name, tag, tarball_path; attempts = 3) |
There was a problem hiding this comment.
fixed with calls to this function in dbf86ff
test/runtests.jl
Outdated
| include("TestComponents.jl") | ||
| using .TestComponents | ||
| #include("TestComponents.jl") | ||
| #using .TestComponents |
There was a problem hiding this comment.
If these are no longer needed (looks like because dcc and html are included in this repo now?) can we delete these lines and the TestComponents.jlfile?
Similar question about dev.jl - you made changes to that file but it's commented out below, is it used?
There was a problem hiding this comment.
@alexj dev.jl is a draft file that I use during the development of a new functionality if I need to call some function, etc. and see how it works. I.e. at the beginning of the development of a new functionality, I disable all tests except dev.jl, after the overall architecture emerges, I disable dev.jl and start writing full-fledged tests
There was a problem hiding this comment.
can we delete these lines and the TestComponents.jlfile?
done in 87533d9
There was a problem hiding this comment.
Got it - that sounds useful, let's just put a comment at the top of dev.jl saying exactly ^^ so others know this - and so future reviewers don't flag it again. In general I have a very strong reaction "don't commit commented-out code, delete it!!!" but this serves a worthwhile purpose.
There was a problem hiding this comment.
let's just put a comment at the top of dev.jl
done in f59aae9
alexcjohnson
left a comment
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Excellent work - excited to see this coming together!
Integration of the core components into the Dash package.
The resources and meta-information of the components are placed in the artifact in the repository https://github.com/waralex/DashCoreResources. Before the release, I will move this repository to the Plotly organization.
Now the resources correspond to dash 2.0.0.
Also, before the release, it is necessary to release new versions of components without functions, but with a warning that
using DashCoreComponents, etc. is depreciated.I also changed the Dash version to 1.0.0