Skip to content

Conversation

@waralex
Copy link
Collaborator

@waralex waralex commented Nov 19, 2021

Added a rule for converting structure ChangedAsset to json within JSON3. Otherwise, _reload-hash would not work if there was an assets folder

@waralex waralex requested a review from alexcjohnson November 19, 2021 08:59
@alexcjohnson
Copy link
Contributor

Thanks - can we add a test for this?

@github-actions github-actions bot added the tests label Nov 20, 2021
@waralex
Copy link
Collaborator Author

waralex commented Nov 20, 2021

can we add a test for this?

Yep, that's a great idea. When implementing the test, I found another small bug - at startup, all files from assets fell into "changed". I fixed it

Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 💃

@waralex waralex merged commit af22273 into dev Nov 24, 2021
@etpinard etpinard deleted the json_changed_assets_fix branch June 13, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants