Throw error on multiple callbacks targeting same output #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @cserteGT3!
I think that would be nice. In principle, this can be understood from the backtrace, but I think that the indication in the error will be more informative
Yep, but if you want to make it perfect, then you can check the error message :) |
Author
|
I changed the error message to be more verbose and added a testcase for it. :) |
waralex
approved these changes
Feb 16, 2022
Collaborator
|
It looks great! Thanks a lot! I plan to release this and another fix early next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a pretty basic check and a simple testcase.
I have two questions:
Closes #163.