Bump HTTP compat to "1", drop support for Julia versions below 1.6 #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttpHelpers/handlers.jl
the operational one is in `.github/workflows/`
etpinard
commented
Feb 2, 2023
src/server.jl
Outdated
| handler = make_handler(app); | ||
| server = Sockets.listen(get_inetaddr(host, port)) | ||
| task = @async HTTP.serve(handler, host, port; server = server, verbose = true) | ||
| task = @async HTTP.serve(handler, host, port; server = server, verbose = debug==true) |
Collaborator
Author
There was a problem hiding this comment.
Personally I would set verbose=false even in under run_server(app; debug=true)
I'd say logs like
┌ Debug: startread called
└ @ HTTP.Servers ~/.julia/packages/HTTP/z8l0i/src/Servers.jl:427
┌ Debug: invoking handler
└ @ HTTP.Servers ~/.julia/packages/HTTP/z8l0i/src/Servers.jl:446
┌ Debug: closeread
└ @ HTTP.Servers ~/.julia/packages/HTTP/z8l0i/src/Servers.jl:452
┌ Debug: closewrite
└ @ HTTP.Servers ~/.julia/packages/HTTP/z8l0i/src/Servers.jl:454
┌ Debug: startread called
└ @ HTTP.Servers ~/.julia/packages/HTTP/z8l0i/src/Servers.jl:427
┌ Debug: invoking handler
└ @ HTTP.Servers ~/.julia/packages/HTTP/z8l0i/src/Servers.jl:446
┌ Debug: closeread
└ @ HTTP.Servers ~/.julia/packages/HTTP/z8l0i/src/Servers.jl:452
┌ Debug: closewrite
└ @ HTTP.Servers ~/.julia/packages/HTTP/z8l0i/src/Servers.jl:454
┌ Debug: startread called
└ @ HTTP.Servers ~/.julia/packages/HTTP/z8l0i/src/Servers.jl:427
┌ Debug: invoking handler
└ @ HTTP.Servers ~/.julia/packages/HTTP/z8l0i/src/Servers.jl:446
┌ Debug: closeread
└ @ HTTP.Servers ~/.julia/packages/HTTP/z8l0i/src/Servers.jl:452
┌ Debug: closewrite
└ @ HTTP.Servers ~/.julia/packages/HTTP/z8l0i/src/Servers.jl:454
┌ Debug: startread called
└ @ HTTP.Servers ~/.julia/packages/HTTP/z8l0i/src/Servers.jl:427
┌ Debug: invoking handler
└ @ HTTP.Servers ~/.julia/packages/HTTP/z8l0i/src/Servers.jl:446
┌ Debug: closeread
└ @ HTTP.Servers ~/.julia/packages/HTTP/z8l0i/src/Servers.jl:452
are pretty much useless for Dash.jl users. Thoughts?
Contributor
There was a problem hiding this comment.
yes I think it's overly verbose for Dash and useless
for `HTTP.serve`, the verbose HTTP logs are too much for Dash.jl users even while debugging. The `verbose` default is `false`, so we can drop it.
Collaborator
Author
|
Ok. I'm going to go ahead and merge this and try to release Dash.jl |
This was referenced Feb 6, 2023
Collaborator
Author
|
Now available as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went ahead and cherry-picked @mind6's commits from #175 unto the current
devbranch.Since we had to disable the Percy tests (ref #177), I would be nice to manually test out this branch before merging it. I'll personally do that starting now.
I'm planning on releasing Dash
v1.2.0early next week.