Release 1.2.1 #187
Merged
Release 1.2.1 #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waralexrom
approved these changes
Feb 8, 2023
Collaborator
waralexrom
left a comment
waralexrom
left a comment
There was a problem hiding this comment.
Yes, the tag should be added after registration. In principle, we can add the ci bot for this, but I've always done it with my hands
Collaborator
Author
UpdateAfter merging this PR, calling In order to not undo the git history, I made a request for a manual review. Hopefully this won't take too long 🤞 |
|
Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, I'm having issue registering the new Dash.jl version.
Commenting
on e8344fb#comments didn't do anything.
On JuliaHub, I get
So I think I might have done
that lead to https://github.com/plotly/Dash.jl/releases/tag/v1.2.0 too soon?
The Julia General Registry wants us to register the new package version before git-tagging I think.
So, unfortunately here's version 1.2.1