Skip to content

Conversation

@etpinard
Copy link
Collaborator

Changed

Internal

Tests

Docs

etpinard added 20 commits August 4, 2023 12:28
these were moved to `DashBase.jl` during
the DashBase v1 push
these are now in `DashBase.jl` since
DashBase v1.

This makes PlotlyBase no longer a `Dash.jl` dep!

Requires is also no longer needed in `Dash.jl`
which includes the DashBase "weakdeps"
so that we can test plotly graph rendering
via the `DashBase` extensions.

since the dash test driver uses
`julia --project` as base command,
we must `cd` into `test/integration`
and setup `Dash` as a dev package manually.
Update the dev docs accordingly!
same version used in `plotly/dash`
Update CircleCI browser tools to `1.4.3`
Even better contributing guidelines
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request tests labels Oct 10, 2023
@etpinard
Copy link
Collaborator Author

Requesting approval from @waralexrom or @alexcjohnson - thanks!!

Copy link
Collaborator

@waralexrom waralexrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Certainly cleaner this way! ✨

@etpinard etpinard merged commit 193d129 into master Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants