Conversation
I'm not sure why the Julia <=1.9 dispatch fails in Julia 1.10. It seems that Julia 1.10 is more strict about element type during convertion to `<:Vector`.
same as for the python version of dash
Use `circleci/browser-tools@1.4.6`
Fix `convert([v], v)` dispatch for Julia 1.10
Collaborator
Author
|
Requesting approval from @waralexrom or @alexcjohnson Dash.jl is broken in Julia 1.10 (released on Monday) One integration test started failing today
(it is related the to devtools) I'll investigate the failure, but I'd like to get a release out ASAP if possible. Thank you very much! |
Collaborator
Author
|
thank you @alexcjohnson - happy new year 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
Dependencyconstructor dispatches for Julia 1.10. It seems that Julia 1.10 is more strict aboutelement type during conversion to
<:VectorFixconvert([v], v)dispatch for Julia 1.10 #231Internal
Tests
circleci/browser-tools@1.4.6#234